Hi Felix, > -----Original Message----- > From: Felix Brack [mailto:[email protected]] > Sent: Tuesday, July 17, 2018 3:13 PM > To: Alexander Graf <[email protected]>; Lokesh Vutla <[email protected]>; > [email protected] > Cc: Wolfgang Denk <[email protected]>; Tom Rini <[email protected]>; Marek Vasut > <[email protected]>; Patrice Chotard > <[email protected]>; Michal Simek <[email protected]>; Simon Glass > <[email protected]>; Alexey Brodkin > <[email protected]>; Bin Meng <[email protected]>; Ley Foon Tan > <[email protected]>; Patrick Delaunay > <[email protected]>; Mario Six <[email protected]>; Stefan Roese > <[email protected]>; Bernhard Messerklinger > <[email protected]> > Subject: Re: [PATCH v2] serial: ns16550: Add register shift variable
[snip] > Adding a separate PORT in ns16550_serial_ids for a particular > architecture, platform or SoC would be an option. However the patch I > posted is much more generic as it offers to set the reg-shift property > for no matter what architecture, platform or SoC. It can also easily be > extended by adding more conditional defaults to the Kconfig file. I'd say we're dealing with just one corner-case here. If I understand a concept of Device Tree it is supposed to describe your hardware. Thus if reg shift exists in your HW it should be explicitly mentioned in your .dts. If for some [historical] reason you have to deal with "incorrect" .dts then I'd prefer to have mentioned quirk with a separate PORT in ns16550_serial_ids instead of adding yet another Kconfig option. Again if OMAP UART is just another flavor of standard 16550 serial port maybe it's a good idea to convert Linux's "drivers/tty/serial/omap-serial.c" to something like "drivers/tty/serial/8250/8250_omap.c" with simultaneous fix of .dtsi? -Alexey _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
