On Sat, Jun 30, 2018 at 7:20 AM, Simon Glass <s...@chromium.org> wrote: > On 29 June 2018 at 11:59, Sam Protsenko <semen.protse...@linaro.org> wrote: >> In case when user provides '-' as USB controller index, like this: >> >> => fastboot - >> >> data abort occurs in strcmp() function in do_fastboot(), here: >> >> if (!strcmp(argv[1], "udp")) >> >> (tested on BeagleBone Black). >> >> That's because argv[1] is NULL when user types in the '-', and null >> pointer dereference occurs in strcmp() (which is ok according to C >> standard specification). So we must validate user input to prevent such >> behavior. >> >> While at it, check also the result of strtoul() function and handle >> error cases properly. >> >> Signed-off-by: Sam Protsenko <semen.protse...@linaro.org> >> --- >> Changes for v2: >> - replace argv check with argc check >> - add mentioning of testing platform in commit message >> >> cmd/fastboot.c | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) > > Reviewed-by: Simon Glass <s...@chromium.org>
Hi Lukasz, Can you please review and merge? Thanks! _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
