Commit 1473b12ad0b3 ("lib: fdtdec: Update ram_base to store ram start
adddress") brings regression on STM32F7 which can't boot.

Use fdtdec_setup_mem_size_base() to setup memory base and size.
Use fdtdec_setup_memory_banksize() to setup memory bank base and size.

Reported-by: Mark Olsson <m...@markolsson.se>
Signed-off-by: Patrice Chotard <patrice.chot...@st.com>
Cc: Mark Olsson <m...@markolsson.se>
Reviewed-by: Vikas Manocha <vikas.mano...@st.com>

---

Changes in v2:
  _ Update value returned by dram_init() and dram_init_banksize

 board/st/stm32f746-disco/stm32f746-disco.c | 35 +++---------------------------
 1 file changed, 3 insertions(+), 32 deletions(-)

diff --git a/board/st/stm32f746-disco/stm32f746-disco.c 
b/board/st/stm32f746-disco/stm32f746-disco.c
index e21cfc6e4955..7c9b1ad82aa1 100644
--- a/board/st/stm32f746-disco/stm32f746-disco.c
+++ b/board/st/stm32f746-disco/stm32f746-disco.c
@@ -21,25 +21,10 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-int get_memory_base_size(fdt_addr_t *mr_base, fdt_addr_t *mr_size)
-{
-       int mr_node;
-
-       mr_node = fdt_path_offset(gd->fdt_blob, "/memory");
-       if (mr_node < 0)
-               return mr_node;
-       *mr_base = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, mr_node,
-                                                     "reg", 0, mr_size, false);
-       debug("mr_base = %lx, mr_size= %lx\n", *mr_base, *mr_size);
-
-       return 0;
-}
 int dram_init(void)
 {
-       int rv;
-       fdt_addr_t mr_base, mr_size;
-
 #ifndef CONFIG_SUPPORT_SPL
+       int rv;
        struct udevice *dev;
        rv = uclass_get_device(UCLASS_RAM, 0, &dev);
        if (rv) {
@@ -48,26 +33,12 @@ int dram_init(void)
        }
 
 #endif
-       rv = get_memory_base_size(&mr_base, &mr_size);
-       if (rv)
-               return rv;
-       gd->ram_size = mr_size;
-       gd->ram_top = mr_base;
-
-       return rv;
+       return fdtdec_setup_mem_size_base();
 }
 
 int dram_init_banksize(void)
 {
-       fdt_addr_t mr_base, mr_size;
-       get_memory_base_size(&mr_base, &mr_size);
-       /*
-        * Fill in global info with description of SRAM configuration
-        */
-       gd->bd->bi_dram[0].start = mr_base;
-       gd->bd->bi_dram[0].size  = mr_size;
-
-       return 0;
+       return fdtdec_setup_memory_banksize();
 }
 
 int board_early_init_f(void)
-- 
1.9.1

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to