On 08/15/2018 08:01 PM, Ley Foon Tan wrote:
> Move reset manager node to top, so reset driver can be load before
> other drivers. Peripheral drivers have dependency on reset framework
> to reset the hardware.
> 
> Signed-off-by: Ley Foon Tan <ley.foon....@intel.com>

This will break the next time you sync DTs with Linux, NAK.
The reset manager should just load when it's needed by other drivers. If
it doesn't work that way, something is seriously broken and that is what
needs to be fixed.

> ---
>  arch/arm/dts/socfpga_stratix10.dtsi | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/dts/socfpga_stratix10.dtsi 
> b/arch/arm/dts/socfpga_stratix10.dtsi
> index ccd3f32..748a436 100644
> --- a/arch/arm/dts/socfpga_stratix10.dtsi
> +++ b/arch/arm/dts/socfpga_stratix10.dtsi
> @@ -87,6 +87,14 @@
>                       reg = <0xffd10000 0x1000>;
>               };
>  
> +             rst: rstmgr@ffd11000 {
> +                     #reset-cells = <1>;
> +                     compatible = "altr,rst-mgr";
> +                     reg = <0xffd11000 0x1000>;
> +                     altr,modrst-offset = <0x20>;
> +                     u-boot,dm-pre-reloc;
> +             };
> +
>               gmac0: ethernet@ff800000 {
>                       compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", 
> "snps,dwmac";
>                       reg = <0xff800000 0x2000>;
> @@ -234,14 +242,6 @@
>                       reg = <0xffe00000 0x100000>;
>               };
>  
> -             rst: rstmgr@ffd11000 {
> -                     #reset-cells = <1>;
> -                     compatible = "altr,rst-mgr";
> -                     reg = <0xffd11000 0x1000>;
> -                     altr,modrst-offset = <0x20>;
> -                     u-boot,dm-pre-reloc;
> -             };
> -
>               spi0: spi@ffda4000 {
>                       compatible = "snps,dw-apb-ssi";
>                       #address-cells = <1>;
> 


-- 
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to