Hi Igor, First, thanks for the reviews!
On Thu, Aug 16, 2018 at 11:38:18AM +0300, Igor Opaniuk wrote: > Hi Eugeniu, > > Why not keep all dependencies on the same line in this case? Simply: > depends LIBAVB && FASTBOOT && PARTITION_UUIDS I guess it's a matter of personal preference (but maybe not entirely). Let's say one needs to replace "depends on PARTITION_UUIDS" with "select PARTITION_UUIDS" due to e.g. a circular dependency detected by Kconfig at some point. For me below two lines: - depends on PARTITION_UUIDS + select PARTITION_UUIDS look more readable and are easier to review than: - depends LIBAVB && FASTBOOT && PARTITION_UUIDS + depends LIBAVB && FASTBOOT + select PARTITION_UUIDS I still can update the patch. Just let me know. > > Regards, > Igor Best regards, Eugeniu. _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
