Hi Jagan,

Jagan Teki <ja...@amarulasolutions.com> wrote on Mon, 3 Sep 2018
13:17:13 +0530:

> On Thu, Aug 16, 2018 at 9:00 PM, Miquel Raynal
> <miquel.ray...@bootlin.com> wrote:
> > UBI selects MTD_PARTITIONS which is the symbol to compile
> > drivers/mtd/mtdpart.c. Unfortunately, the symbol was not defined in
> > Kconfig and this worked only with board files defining it. Fix this by
> > adding a boolean in Kconfig so boards defined by defconfig files only
> > will work as expected.
> >
> > Signed-off-by: Miquel Raynal <miquel.ray...@bootlin.com>
> > ---
> >  drivers/mtd/Kconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> > index 9341d518f3..d98457e223 100644
> > --- a/drivers/mtd/Kconfig
> > +++ b/drivers/mtd/Kconfig
> > @@ -1,5 +1,8 @@
> >  menu "MTD Support"
> >
> > +config MTD_PARTITIONS
> > +       bool
> > +  
> 
> I think I can drop this patch, along with
> "mtd: declare MTD_PARTITIONS symbol in Kconfig"

Oh I see what you mean! It looks like the problem reported here has
already been fixed by:

commit 9c5b00973bceb7c0192bd6b03672d69b092700b4
Author: Adam Ford <aford...@gmail.com>
Date:   Sat Jul 7 22:18:22 2018 -0500

    Convert CONFIG_MTD_PARTITIONS et al to Kconfig
    
    This converts the following to Kconfig:
       CONFIG_MTD_PARTITIONS
       CONFIG_MTD_DEVICE
    
    Signed-off-by: Adam Ford <aford...@gmail.com>

And indeed I saw the double entry when I rebased and removed the
duplicate. So yes, you can drop this one, and I will drop the unneeded
patch in the "Clean MTD partition..." series.

Good catch!
Miquèl
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to