On 09/04/2018 09:33 AM, Patrice CHOTARD wrote: > Hi Marek > > On 09/03/2018 06:16 PM, Marek Vasut wrote: >> On 09/03/2018 03:39 PM, Patrice Chotard wrote: >>> Add vbus-supply regulator support. >>> On some board vbus is not controlled by the phy but by >>> an external regulator. >>> >>> Signed-off-by: Patrice Chotard <[email protected]> >>> --- >>> >>> Changes in v4: >>> - Remove useless dev->name in dev_dgb() >> >> Two remaining nits, can you pull the regulator handling into separate >> functions and put ifdef arounds those, with empty default >> implementation? That way, the ifdefs won't be spread throughout the code. > > Agree it will be more readable. > >> >> Also, rebase on u-boot-usb/master please. > > Ok > > Thanks
But the rest is good, thanks. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
