Hi Simon and Bin, Do I need to send the standalone patch 1/2 in version 2?
Thanks, Zhiqiang > -----Original Message----- > From: s...@google.com <s...@google.com> On Behalf Of Simon Glass > Sent: 2018年10月9日 11:41 > To: Bin Meng <bmeng...@gmail.com> > Cc: Z.q. Hou <zhiqiang....@nxp.com>; U-Boot Mailing List > <u-boot@lists.denx.de>; Christian Gmeiner <christian.gmei...@gmail.com>; > Tuomas Tynkkynen <tuomas.tynkky...@iki.fi>; Bernhard Messerklinger > <bernhard.messerklin...@br-automation.com>; Masahiro Yamada > <yamada.masah...@socionext.com>; Mingkai Hu <mingkai...@nxp.com>; > M.h. Lian <minghuan.l...@nxp.com> > Subject: Re: [PATCH 2/2] pci: Change the first CFG read to Vendor ID in > enumeration > > Hi Bin, > > On 8 October 2018 at 02:54, Bin Meng <bmeng...@gmail.com> wrote: > > On Mon, Oct 8, 2018 at 4:36 PM Zhiqiang Hou <zhiqiang....@nxp.com> > wrote: > >> > >> From: Hou Zhiqiang <zhiqiang....@nxp.com> > >> > >> As the PCIe specification recommend reading the Vendor ID register to > >> determine if a Function is present, read the Vendor ID of a > >> non-existent Function must not result in system error, so we'd better > >> make the first CFG read to Vendor ID instead of Header Type register > >> in the PCIe enumeration. > >> > >> Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com> > >> --- > >> drivers/pci/pci.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > > > > Simon, do we need fix the non-DM version or adding new "capability" to > > the non-DM drivers? I guess the answer is no and we should set some > > deadline for PCI DM conversion too? > > We should not fix or add new features to non-DM PCI. No one should be using > it at this point. > > I agree about the deadline. Do you want to send a patch? > > Regards, > Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
