Hi Fabio,
> -----Original Message-----
> From: Fabio Estevam [mailto:feste...@gmail.com]
> Sent: 2018年10月26日 8:50
> To: sba...@denx.de
> Cc: Peng Fan <peng....@nxp.com>; u-boot@lists.denx.de; Fabio Estevam
> <feste...@gmail.com>
> Subject: [PATCH] ARM: dts: fsl-imx8qxp-mek: Move regulator outside
> "simple-bus"
>
> Commit 3c28576bb0f0 ("arm: dts: imx8qxp: fix build warining") fixed the dts
> warning by removing the unnecessary #address-cells/#size-cells, but the
> recommendation for regulators is not to place them under "simple-bus", so
> move the reg_usdhc2_vmmc regulator accordingly.
>
> Signed-off-by: Fabio Estevam <feste...@gmail.com>
> ---
> arch/arm/dts/fsl-imx8qxp-mek.dts | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/dts/fsl-imx8qxp-mek.dts
> b/arch/arm/dts/fsl-imx8qxp-mek.dts
> index c14e184..adab494 100644
> --- a/arch/arm/dts/fsl-imx8qxp-mek.dts
> +++ b/arch/arm/dts/fsl-imx8qxp-mek.dts
> @@ -16,18 +16,14 @@
> stdout-path = &lpuart0;
> };
>
> - regulators {
Will it be better to keep regulators node? Currently it only has the usdhc2,
but in future,
the usb regulator will also be added.
Thanks,
Peng.
> - compatible = "simple-bus";
> -
> - reg_usdhc2_vmmc: usdhc2-vmmc {
> - compatible = "regulator-fixed";
> - regulator-name = "SD1_SPWR";
> - regulator-min-microvolt = <3000000>;
> - regulator-max-microvolt = <3000000>;
> - gpio = <&gpio4 19 GPIO_ACTIVE_HIGH>;
> - off-on-delay = <3480>;
> - enable-active-high;
> - };
> + reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> + compatible = "regulator-fixed";
> + regulator-name = "SD1_SPWR";
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + gpio = <&gpio4 19 GPIO_ACTIVE_HIGH>;
> + off-on-delay = <3480>;
> + enable-active-high;
> };
> };
>
> --
> 2.7.4
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
