On Wed, Nov 14, 2018 at 2:53 PM Wolfgang Denk <w...@denx.de> wrote:
>
> Dear Jagan,
>
> In message
> <camty3zayecwb8_wpkqev+v1ntfjxrrkukkeowx0zbnaeuh9...@mail.gmail.com> you
> wrote:
> >
> > These changes were fully tested, not an immediate changes. What I mean
> > a immediate fix here is not for the series, for the comment mentioned
> > by Marek about patch 1/5.
>
> Come on. You mean this code:
>
> >> else if (env_get_f("mtdparts", tmp_parts, sizeof(tmp_parts) != -1))
>
> was "fully tested"? It may have been compile clean, but it
> certainly was functionally broken, so it was NOT sufficiently
> tested. Just running travis is simply not enough to claim the stuff
> was tested.
One thing I can say here is, I didn't test 1/5 or either the series
since I don't have relevant hardware to produce the issue. I commented
"about testing" based on author testing, Tested-by credit and how much
this is needed for the release since I would trying to send the PR.
Sorry if you understand differently, but I'm still on the same page
what I mentioned in previous mail.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
