Hi Jagan, On Wed, Nov 14, 2018 at 03:28:06PM +0530, Jagan Teki wrote: > - Drop unnecessary include files. > - Rename platform_data include file as spi_pl022.h from > pl022_spi.h, this is generic notation used for spi platdat > include files. >
You tell it yourself here, there are two changes. IMHO, it would make
sense to have two patches.
Thanks,
Quentin
> Cc: Quentin Schulz <quentin.sch...@bootlin.com>
> Signed-off-by: Jagan Teki <ja...@amarulasolutions.com>
> ---
> Changes for v2:
> - none
>
> drivers/spi/pl022_spi.c | 7 +------
> include/dm/platform_data/{pl022_spi.h => spi_pl022.h} | 6 +++---
> 2 files changed, 4 insertions(+), 9 deletions(-)
> rename include/dm/platform_data/{pl022_spi.h => spi_pl022.h} (81%)
>
> diff --git a/drivers/spi/pl022_spi.c b/drivers/spi/pl022_spi.c
> index 05f4f6f481..32bb8c8d21 100644
> --- a/drivers/spi/pl022_spi.c
> +++ b/drivers/spi/pl022_spi.c
> @@ -9,16 +9,11 @@
> * Driver for ARM PL022 SPI Controller.
> */
>
> -#include <asm/io.h>
> #include <clk.h>
> #include <common.h>
> #include <dm.h>
> -#include <dm/platform_data/pl022_spi.h>
> -#include <fdtdec.h>
> -#include <linux/bitops.h>
> -#include <linux/bug.h>
> +#include <dm/platform_data/spi_pl022.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> #include <spi.h>
>
> #define SSP_CR0 0x000
> diff --git a/include/dm/platform_data/pl022_spi.h
> b/include/dm/platform_data/spi_pl022.h
> similarity index 81%
> rename from include/dm/platform_data/pl022_spi.h
> rename to include/dm/platform_data/spi_pl022.h
> index 57d12ac912..36e645c836 100644
> --- a/include/dm/platform_data/pl022_spi.h
> +++ b/include/dm/platform_data/spi_pl022.h
> @@ -7,8 +7,8 @@
> * in ofdata_to_platdata.
> */
>
> -#ifndef __PL022_SPI_H__
> -#define __PL022_SPI_H__
> +#ifndef __spi_pl022_h
> +#define __spi_pl022_h
>
> struct pl022_spi_pdata {
> fdt_addr_t addr;
> @@ -16,4 +16,4 @@ struct pl022_spi_pdata {
> unsigned int freq;
> };
>
> -#endif
> +#endif /* __spi_pl022_h */
> --
> 2.18.0.321.gffc6fa0e3
>
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
