On 11/14/2018 09:29 AM, Alexander Graf wrote:
On 09/23/2018 10:38 PM, Heinrich Schuchardt wrote:
Remove unused import and variables.
Remove superfluous semicolons.
Reformat long lines.
Use four spaces indention.

Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>

Does this pass Travis for you?

I'm getting the following error and this is the only patch touching watchdog code:

=================================== FAILURES =================================== ______________________ test_efi_selftest_watchdog_reboot _______________________ u_boot_console = <u_boot_console_exec_attach.ConsoleExecAttach object at 0x7f7e70fdb950>
@pytest.mark.buildconfigspec('cmd_bootefi_selftest')
def test_efi_selftest_watchdog_reboot(u_boot_console):
u_boot_console.run_command(cmd='setenv efi_selftest list')
output = u_boot_console.run_command('bootefi selftest')
      assert '\'watchdog reboot\'' in output
E assert "'watchdog reboot'" in "\x1b7999;999H\x1b8Found 0 disks\r\r\nWARNING: booting without device tree\r\r\n\r\r\nAvailable tests:\r\r\n'block ima...put' - on request\r\r\n'extended text input' - on request\r\r\n'text output'\r\r\n'unicode collation'\r\r\n'variables'"
test/py/tests/test_efi_selftest.py:45: AssertionError

I can confirm that removing the patch does fix the issue. My guess is the newline in the watchdog code.

I'll drop the patch from my queue for now.


Alex

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to