On Thu, Nov 15, 2018 at 12:22:31PM -0800, Simon Glass wrote: > On 15 November 2018 at 11:51, Andy Shevchenko <[email protected]> > wrote: > > On Thu, Nov 15, 2018 at 9:46 PM Simon Glass <[email protected]> wrote: > >> On 15 November 2018 at 09:58, Andy Shevchenko > >> <[email protected]> wrote:
> >> > +int serial_getinfo(struct serial_device_info *info) > >> > >> This should use driver model, so: > >> > >> int serial_getinfo(struct udevice *dev, struct serial_device_info *info) > > > > Oh, sure! I have to withdraw this comment based on two points: - the rest of API is using it in this way - it is all about current console IIUC, so, anyway we would need the same code to retrieve it Are you still thinking that serial_getinfo(dev, info) would be preferable? -- With Best Regards, Andy Shevchenko _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
