On Sat, Dec 08, 2018 at 05:26:49PM +0100, Stefano Babic wrote: > Hi Marek, Robert, > > On 05/12/18 15:52, Marek Vasut wrote: > > From: Robert Berger <[email protected]> > > > > Signed-off-by: Robert Berger <[email protected]> > > > > I received this off-list from Robert, it's a bugfix to mkimage, where > > the IH_TYPE_ enumeration changed recently and broke backward mkimage > > backward compatibility. > > > > That's true - new image type must be always appended for compatible reason. > > > Peng, can you respin the patch, test it and repost it ? Thanks > > I am reviewing and applying Peng's - but Peng posted a patch for i.MX8M, > patch for i.MX8 was already applied. > > If nobody complains, I fix this myself by applying Peng's i.MX8M (not > MX8) patch, I mean this one: > > http://patchwork.ozlabs.org/patch/1000376/ > > Note: this also breaks compatibility
I think the first problem is that the comment "Do not change values for backward compatibility." is not clear enough because I see lots of middle of the list insertions which in turn change all of the values that follow. A downside of an enum I suppose. What we need to do is yank the IMX8 part out to fix all of the broken images, and put the new ones at the back, and Cc the various distro folks as they'll want to make sure to pick this fix up. -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
