Hi Simon, On Thu, 13 Dec 2018 at 02:45, Simon Goldschmidt <[email protected]> wrote: > > Hi Tom, > > On Tue, Dec 4, 2018 at 5:51 AM Tom Rini <[email protected]> wrote: > > > > On Thu, Nov 29, 2018 at 06:21:11PM -0500, Tom Rini wrote: > > > > > Given that at this point the MMC subsystem itself has been migrated > > > along with a number of subsystem drivers, formalize a deadline for > > > migration. > > > > > > Reviewed-by: Simon Glass <[email protected]> > > > Cc: Jaehoon Chung <[email protected]> > > > Signed-off-by: Tom Rini <[email protected]> > > > Reviewed-by: Simon Goldschmidt <[email protected]> > > > Reviewed-by: Philipp Tomsich <[email protected]> > > > > Applied to u-boot/master, thanks! > > I have finally found the time to test current mainline on all our > board configs and now I still get the warning "This board does not use > CONFIG_DM_MMC". Supposedly this is because I have CONFIG_BLK disabled > (because of size limitations: this U-Boot image runs from FPGA and > just configures the eMMC without loading files from it). > > Would it make sense to change the test like this: > > diff --git a/Makefile b/Makefile > index 0d11ff9797..41bde15b74 100644 > --- a/Makefile > +++ b/Makefile > @@ -920,7 +920,7 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) > @echo "before sending patches to the mailing list." > @echo "====================================================" > endif > -ifeq ($(CONFIG_MMC),y) > +ifeq ($(CONFIG_MMC)$(CONFIG_BLK),yy) > ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) > @echo "===================== WARNING ======================" > @echo "This board does not use CONFIG_DM_MMC. Please update" > > Is it intentional that CONFIG_BLK needs to be enabled?
Yes it is, unless you don't actually use block devices. What is the goal of initing eMMC without using it? Regards, Simon _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
