On 14/12/18 15:18, Philipp Tomsich wrote: > Stefano, > >> On 14.12.2018, at 15:04, Stefano Babic <sba...@denx.de> wrote: >> >> Commit a2b96ece5be146f4995d737f047e5bbb76079b8f breaks the enumeration >> of the Image Types. New image types can be appended, but they cannot be >> inserted in the list else backward compatibility is broken. >> This restores the images types as before 2018.11 and move i.MX8 related >> images at the end. > > Adding a clearer indication than the "Do not change values for backward > compatibility” (it might not be apparent to the casual reader that this refers > to integer value assigned to enum entries) in the comment above the enum > that this to be understood as “append-only” might avoid future issues.
I'll do it in V2. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
