Am 17.12.18 um 02:01 schrieb Ramon Fried:
> Some architectures (MIPS) needs mapping to access IOMEM.
> Fix that.
> 
> Fixes: f1dcc19b213d ("net: macb: Convert to driver model")
> 
> Signed-off-by: Ramon Fried <[email protected]>
> ---
> 
>  drivers/net/macb.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 94c89c762b..6e1b479813 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -36,6 +36,7 @@
>  #include <miiphy.h>
>  
>  #include <linux/mii.h>
> +#include <linux/io.h>
>  #include <asm/io.h>
>  #include <asm/dma-mapping.h>
>  #include <asm/arch/clk.h>
> @@ -1149,9 +1150,18 @@ int __weak macb_late_eth_ofdata_to_platdata(struct 
> udevice *dev)
>  
>  static int macb_eth_ofdata_to_platdata(struct udevice *dev)
>  {
> +     fdt_addr_t addr;
> +     fdt_size_t size;
> +     int node = dev_of_offset(dev);
>       struct eth_pdata *pdata = dev_get_platdata(dev);
>  
> -     pdata->iobase = devfdt_get_addr(dev);
> +     addr = fdtdec_get_addr_size(gd->fdt_blob, node, "reg", &size);
> +     if (addr == FDT_ADDR_T_NONE)
> +             return -EINVAL;
> +
> +     pdata->iobase = (phys_addr_t)ioremap(addr, size);
> +     if (!pdata->iobase)
> +             return -EINVAL;
>  
>       return macb_late_eth_ofdata_to_platdata(dev);
>  }
> 

you should use dev_remap_addr() to avoid all the boiler plate code

-- 
- Daniel

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Reply via email to