On Wed, Dec 12, 2018 at 03:24:44PM +0800, Shawn Guo wrote:
> Commit 4687919684e0 ("serial: Remove DM_FLAG_PRE_RELOC flag in various
> drivers") essentially drops flag DM_FLAG_PRE_RELOC from serial_pl01x
> driver for Poplar platform, because the platform falls into the
> following strategy category made by the commit.
>
> Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for
> drivers that support both statically declared devices and
> configuration from device tree
>
> Before the commit lands, Poplar platform works by statically declaring
> pl011 serial device via U_BOOT_DEVICE() with DM_FLAG_PRE_RELOC flag set
> in the driver. But since Poplar also supports device configuration from
> device tree, the commit practically drops the flag for Poplar, and hence
> breaks the platform from booting.
>
> This patch changes platform code and device tree to initiate pl011
> serial device from device tree rather than static declaration, so that
> above strategy about DM_FLAG_PRE_RELOC applies to Poplar, and therefore
> the reported boot failure gets fixed.
>
> Reported-by: Igor Opaniuk <[email protected]>
> Fixes: 4687919684e0 ("serial: Remove DM_FLAG_PRE_RELOC flag in various
> drivers")
> Cc: Bin Meng <[email protected]>
> Cc: Simon Glass <[email protected]>
> Signed-off-by: Shawn Guo <[email protected]>
> Reviewed-by: Igor Opaniuk <[email protected]>
> Tested-by: Igor Opaniuk <[email protected]>
> Reviewed-by: Bin Meng <[email protected]>Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
