On 12/19/2018 05:53 AM, Ang, Chee Hong wrote: > On Tue, 2018-12-18 at 18:47 +0100, Marek Vasut wrote: >> On 12/18/2018 09:54 AM, chee.hong....@intel.com wrote: >>> >>> From: "Ang, Chee Hong" <chee.hong....@intel.com> >>> >>> Summary of v6 changes: >>> - Patch 1/4 and 4/4 are unchanged >>> - Patch 2/4: >>> - fixed compilation warnings in drivers/fpga/stratix10.c >>> - Patch 3/4: >>> - socfpga_fpga_add() in misc.c >>> - define fpga descriptor structure in misc_arria10.c, misc_gen5.c >>> & >>> misc_s10.c respectively >>> - removed for-loop in socfpga_fpga_add() (only 1 FPGA device >>> added) >>> >>> v5 patchsets: >>> https://lists.denx.de/pipermail/u-boot/2018-November/349670.html >>> >>> Ang, Chee Hong (4): >>> arm: socfpga: stratix10: Add macros for mailbox's arguments >>> arm: socfpga: stratix10: Add Stratix 10 FPGA Reconfiguration >>> Driver >>> arm: socfpga: stratix10: Add Stratix10 FPGA into FPGA device >>> table >>> arm: socfpga: stratix10: Enable Stratix10 FPGA Reconfiguration >>> >>> arch/arm/mach-socfpga/include/mach/mailbox_s10.h | 6 + >>> arch/arm/mach-socfpga/include/mach/misc.h | 4 +- >>> arch/arm/mach-socfpga/misc.c | 26 +- >>> arch/arm/mach-socfpga/misc_arria10.c | 22 +- >>> arch/arm/mach-socfpga/misc_gen5.c | 22 +- >>> arch/arm/mach-socfpga/misc_s10.c | 22 ++ >>> configs/socfpga_stratix10_defconfig | 1 + >>> drivers/fpga/Kconfig | 11 + >>> drivers/fpga/Makefile | 1 + >>> drivers/fpga/altera.c | 6 + >>> drivers/fpga/stratix10.c | 288 >>> +++++++++++++++++++++++ >>> include/altera.h | 8 + >>> 12 files changed, 389 insertions(+), 28 deletions(-) >>> create mode 100644 drivers/fpga/stratix10.c >> I take it this fixes the previous stratix 10 build breakage, right ? >> let's see what travis says. > Yes. Actually they are just compilation warnings to me. Your travis's > build settings treat all warning as error. Please let me know about the > travis report. Thanks.
+drivers/fpga/stratix10.c: In function 'reconfig_status_polling_resp': +drivers/fpga/stratix10.c:102:9: error: implicit declaration of function 'mbox_get_fpga_config_status' [-Werror=implicit-function-declaration] + ret = mbox_get_fpga_config_status(MBOX_RECONFIG_STATUS); + ^~~~~~~~~~~~~~~~~~~~~~~~~~~ +cc1: all warnings being treated as errors +make[3]: *** [drivers/fpga/stratix10.o] Error 1 +make[2]: *** [drivers/fpga] Error 2 +make[1]: *** [drivers] Error 2 +make: *** [sub-make] Error 2 Seems like a compile error to me. Please at least build the patches before posting them. See my other email. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot