Hi Marek, > On 1/2/19 10:43 AM, Lukasz Majewski wrote: > > Hi Marek, > > > >> On 1/2/19 12:37 AM, Lukasz Majewski wrote: > >>> This commit fixes warnings produced by newest in u-boot DTC > >>> compiler: 'unnecessary #address-cells/#size-cells without "ranges" > >>> or child "reg" property' > >>> > >>> Signed-off-by: Lukasz Majewski <lu...@denx.de> > >> > >> I presume the DTSIs are taken from Linux, is this a backport from > >> Linux then ? > > > > Regarding Linux - with Version: DTC 1.4.7-gc86da84d and make W=1 I > > do not see those warnings as in scripts/Makefile.lib : > > > > # Disable noisy checks by default > > ifeq ($(findstring 1,$(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),) > > DTC_FLAGS += -Wno-unit_address_vs_reg \ > > -Wno-unit_address_format \ > > -Wno-avoid_unnecessary_addr_size \ > > > > those warnings are disabled (-Wno-avoid_unnecessary_addr_size). > > > > On the other hand - in u-boot those warnings are checked (maybe are > > necessary for OF_PLATDATA correct operation?). > > No, keep the DTs synced and fix things upstream (in Linux) if needed, > then backport the fixes.
Please correct my understanding if I get this wrong. Do you recommend to send this patch to Linux upstream to fix warnings, which are disabled (no checked and not present) by default in Linux ? After this patch is accepted in Linux - I shall backport it to u-boot ? > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgpdfeFvFmNTC.pgp
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
