> -----Original Message----- > From: Simon Goldschmidt [mailto:[email protected]] > Sent: Saturday, December 29, 2018 5:04 AM > To: Marek Vasut <[email protected]>; Ooi, Joyce <[email protected]>; Michal > Simek <[email protected]>; Siva Durga Prasad Paladugu > <[email protected]> > Cc: [email protected]; Chee, Tien Fong <[email protected]>; See, > Chin Liang <[email protected]> > Subject: Re: [U-Boot] [PATCH] rsa: read out public_exponent value based on 32- > bit alignment > > Am 28.12.2018 um 19:44 schrieb Marek Vasut: > > On 12/28/18 2:32 PM, Ooi, Joyce wrote: > >>> -----Original Message----- > >>> From: Marek Vasut [mailto:[email protected]] > >>> Sent: Friday, December 28, 2018 6:05 PM > >>> To: Ooi, Joyce <[email protected]>; Michal Simek > >>> <[email protected]>; Siva Durga Prasad Paladugu > >>> <[email protected]> > >>> Cc: [email protected]; See, Chin Liang > >>> <[email protected]>; Chee, Tien Fong > >>> <[email protected]>; Tan, Ley Foon <[email protected]> > >>> Subject: Re: [PATCH] rsa: read out public_exponent value based on > >>> 32-bit alignment > >>> > >>> On 12/28/18 8:30 AM, Ooi, Joyce wrote: > >>>> Hi Marek, > >>> > >>> Hi, > >>> > >>>> Any comments about this? > >>> > >>> Use get_unaligned() ? > >> It seems that if USE_HOSTCC is enabled, get_unaligned_* can't be used. > > > > Can this be fixed ? > > I was working on a patch (or series?) to make USE_HOSTCC more generic (i.e. > concentrate the HOSTCC specific things in some header files, > hopefully) as I have stumbled accross this when adding > compression/uncompression to mkimage, but I haven't found the time to > complete this, yet. > > Nevertheless, I think this is where we should go, rather then add yet more > #ifdef > USE_HOSTCC to C files... > > Regards, > Simon Can you please help to fix this, Simon? I'm not too familiar with USE_HOSTCC.. Thanks.
> > > > >> In lib/rsa/rsa-mod-exp.c, > >> #ifndef USE_HOSTCC > >> .. > >> #include <asm/unaligned.h> > >> #else > >> #include "fdt_host.h" > >> #include "mkimage.h" > >> #include <fdt_support.h> > >> #endif > >> > >> So, to make it more generic (with or without USE_HOSTCC enabled), I > >> read out the public_exponent as two 32-bit datas and then > >> concatenating them into a 64-bit data. > > > > See above -- I'd much rather see the get_unaligned() fixed and used. > > _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
