It does not make sense to check if argc < 2 a second time, especially after accessing argv[1].
Signed-off-by: Heinrich Schuchardt <[email protected]> --- cmd/ubi.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/ubi.c b/cmd/ubi.c index a12ac703eb..c511a2fb76 100644 --- a/cmd/ubi.c +++ b/cmd/ubi.c @@ -472,12 +472,8 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) if (argc < 2) return CMD_RET_USAGE; - if (strcmp(argv[1], "detach") == 0) { - if (argc < 2) - return CMD_RET_USAGE; - + if (strcmp(argv[1], "detach") == 0) return ubi_detach(); - } if (strcmp(argv[1], "part") == 0) { const char *vid_header_offset = NULL; -- 2.20.1 _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
