Hi Alexey, On Wed, Jan 9, 2019 at 9:36 AM Alexey Brodkin <alexey.brod...@synopsys.com> wrote: > > Hi Simon, > > > -----Original Message----- > > From: Simon Goldschmidt [mailto:simon.k.r.goldschm...@gmail.com] > > Sent: Tuesday, January 8, 2019 12:14 AM > > To: Marek Vasut <ma...@denx.de> > > Cc: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com>; Patrice Chotard > > <patrice.chot...@st.com>; > > Simon Glass <s...@chromium.org>; Anup Patel <a...@brainfault.org>; Lokesh > > Vutla <lokeshvu...@ti.com>; > > Alexey Brodkin <alexey.brod...@synopsys.com>; Patrick Delaunay > > <patrick.delau...@st.com>; Marek Vasut > > <marek.va...@gmail.com>; u-boot@lists.denx.de; Álvaro Fernández Rojas > > <nolt...@gmail.com>; Ryder Lee > > <ryder....@mediatek.com>; Vikas Manocha <vikas.mano...@st.com>; Alexander > > Graf <ag...@suse.de>; Weijie > > Gao <weijie....@mediatek.com> > > Subject: [PATCH v1 3/4] serial: add an of-platdata driver for > > "snps,dw-apb-uart" > > > > Add a driver for the "snps,dw-apb-uart" used in socfpga and others. > > > > This driver is required to get OF_PLATDATA to work for socfpga. > > It uses the ns16550 driver, converting the platdata from of-platdata > > go the ns16550 format. > > > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com> > > --- > > > > drivers/serial/Kconfig | 10 ++++++++ > > drivers/serial/Makefile | 1 + > > drivers/serial/serial_dw_apb.c | 42 ++++++++++++++++++++++++++++++++++ > > 3 files changed, 53 insertions(+) > > create mode 100644 drivers/serial/serial_dw_apb.c > > > > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig > > index b7ff2960ab..10addd3309 100644 > > --- a/drivers/serial/Kconfig > > +++ b/drivers/serial/Kconfig > > @@ -511,6 +511,16 @@ config BCM283X_PL011_SERIAL > > that supports automatic disable, so that it only gets used when > > the UART is actually muxed. > > > > +config DESIGNWARE_SERIAL > > + bool "DesignWare UART support" > > + depends on DM_SERIAL && SPL_OF_PLATDATA > > Might be a bit naïve question but why depend on SPL_OF_PLATDATA only?
Because my focus has been to get OF_PLATDATA running on my socfpga board. But since Marek seems to be opposed, I guess I'll drop this series and try to find a different way to squeeze out the bytes I need. > What about CONFIG_OF_EMBED? > > I'd happily switch my ARC boards on this driver and get rid of all > CONFIG_SYS_NS16550_xxx nonsense in include/configs/myboardname.h You're right there, this would be a good idea for socfpga as well. Maybe I'll continue that line some day, but I don't have immediate plans for this. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
