Hi Tom, > -----Original Message----- > From: Tom Rini <[email protected]> > Sent: Wednesday, January 16, 2019 7:25 PM > To: Alexey Brodkin <[email protected]> > Cc: [email protected]; [email protected]; Michal Simek > <[email protected]>; Simon > Glass <[email protected]> > Subject: Re: [PATCH] ARC: Move ENV_SIZE and ENV_OFFSET to Kconfig > > On Wed, Jan 16, 2019 at 04:22:22PM +0000, Alexey Brodkin wrote: > > Hi Tom, > > > > > -----Original Message----- > > > From: Tom Rini <[email protected]> > > > Sent: Wednesday, January 16, 2019 7:19 PM > > > To: Alexey Brodkin <[email protected]> > > > Cc: [email protected]; [email protected]; Michal Simek > > > <[email protected]>; > Simon > > > Glass <[email protected]> > > > Subject: Re: [PATCH] ARC: Move ENV_SIZE and ENV_OFFSET to Kconfig > > > > > > On Wed, Jan 16, 2019 at 07:11:15PM +0300, Alexey Brodkin wrote: > > > > > > > Join the party of some ARM boards and drop more > > > > items from include/configs/xxx.h. > > > > > > > > Signed-off-by: Alexey Brodkin <[email protected]> > > > > Cc: Michal Simek <[email protected]> > > > > Cc: Simon Glass <[email protected]> > > > > Cc: Tom Rini <[email protected]> > > > > --- > > > > [snip] > > > > > > config ENV_OFFSET > > > > hex "Environment Offset" > > > > @@ -441,6 +441,7 @@ config ENV_OFFSET > > > > default 0x88000 if ARCH_SUNXI > > > > default 0xE0000 if ARCH_ZYNQ > > > > default 0x1E00000 if ARCH_ZYNQMP > > > > + default 0 > > > > > > Please make this "if ARC", thanks! > > > > Actually I don't like having here listed all the boards > > because with more boards/arches moving ENV settings to Kconfig > > we'll get here all of them listed at some point. > > Why default ENV_OFFSET [as well as] ENV_SIZE are not set in > > arch/soc/board top-level Kconfig? > > I believe the answer is that having config FOO prompt in one place and N > config FOO values results in lots of churn in the defconfig files when > they get re-synced. So yes, having N lines of default X if Y with the > prompt is what we want, at least until everything is converted and then > we can see if no, really, moving the defaults to some defined / > consistent locations doesn't result in so much churn.
Ok that's fine by me. Sending a re-spin. -Alexey _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
