On 18.01.19 14:03, Anup Patel wrote: > > >> -----Original Message----- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Friday, January 18, 2019 5:22 PM >> To: Anup Patel <anup.pa...@wdc.com>; Rick Chen <r...@andestech.com>; >> Bin Meng <bmeng...@gmail.com>; Joe Hershberger >> <joe.hershber...@ni.com>; Lukas Auer <lukas.a...@aisec.fraunhofer.de>; >> Masahiro Yamada <yamada.masah...@socionext.com>; Simon Glass >> <s...@chromium.org> >> Cc: Palmer Dabbelt <pal...@sifive.com>; Paul Walmsley >> <paul.walms...@sifive.com>; Atish Patra <atish.pa...@wdc.com>; >> Christoph Hellwig <h...@infradead.org>; U-Boot Mailing List <u- >> b...@lists.denx.de> >> Subject: Re: [PATCH v2 05/11] net: macb: Fix GEM hardware detection >> >> >> >> On 18.01.19 12:19, Anup Patel wrote: >>> From: Atish Patra <atish.pa...@wdc.com> >>> >>> Fix MID bit field check to correctly identify all GEM hardwares. >>> >>> The check is updated as per macb driver in Linux location: >>> <linux_sources>/drivers/net/ethernet/cadence/macb_main.c:259 >>> >>> Signed-off-by: Atish Patra <atish.pa...@wdc.com> >> >> This is missing your SoB. > > Sure, I will add my SoB. > > Since the work was done by Atish independently, I thought my > SoB is not required.
Imagine the SoB as a marker for "this went through my hands". If you send a patch from someone else - even though you did modify a single line - it still went through your hands and thus your SoB should occur at the end. Similarly the first SoB usually means "this was the original author". So imagine you started to work on a patch, then Atish improved it and eventually you send it out, the SoB chain would look like this: Signed-off-by: Anup Patel <anup.pa...@wdc.com> Signed-off-by: Atish Patra <atish.pa...@wdc.com> Signed-off-by: Anup Patel <anup.pa...@wdc.com> But you don't have to be too nit-picky about that part. The one thing people will care about is that the original author is in the SoB list and that your SoB is at the end of the list, because you are the one sending the patch set. Alex _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
