Hi Baruch,
On 30/01/19 10:48, Baruch Siach wrote:
> Hi Stefano,
>
> On Wed, Jan 30, 2019 at 10:40:19AM +0200, sba...@denx.de wrote:
>>> There is no need to set the ARCH variable when building U-Boot. In fact,
>>> the ARCH name in U-Boot is 'arm'.
>>> Signed-off-by: Baruch Siach <bar...@tkos.co.il>
>>
>> Applied to u-boot-imx, master, thanks !
>
> Thanks.
>
> What about patch #1 in this series? It fixes build failure when /bin/sh is
> not
> bash.
>
I suffer from the prejudice that a single "=" is always bad in a
comparison.....I am surely influenced from bugs in C/C++ due to a
missing "=" in my experience as developer.
I searched for such as comparison in other parts of build to justify
this patch : I have just found it in "test/fs" (ok, this is not really
part of build) and in ./lib/lzma/import_lzmasdk.sh. I fully agree that
this could be just a problem of mine, and I confess I was already merged
your patch and then removed again..
Apart of this, it looks like that a single "=" was already avoided in
U-Boot scripts like the pest. Apart of the single entry I found above,
it was avoided..
What about to substitute "=" with an explicit "-eq" ? Like :
[ $f -eq "spl/u-boot-spl-ddr.bin" ]
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
