Hi Philipp On Thu, Feb 14, 2019 at 5:36 PM Philipp Tomsich <philipp.toms...@theobroma-systems.com> wrote: > > > > > On 14.02.2019, at 16:58, Michael Trimarchi <mich...@amarulasolutions.com> > > wrote: > > > > Set two rank timing and exit self-refresh timing seems not done > > properly. We know use the same write that we are using > > on H5 silicon. Tested was done in A33 allwinner cpu, dual rank > > connection connected with two MT41K512M16HA-125:A memory model. > > Memory is configure as DDR3 1.5V > > > > Signed-off-by: Michael Trimarchi <mich...@amarulasolutions.com> > > --- > > > > V1->V2: adjust commit message > > > > --- > > arch/arm/mach-sunxi/dram_sun8i_a33.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-sunxi/dram_sun8i_a33.c > > b/arch/arm/mach-sunxi/dram_sun8i_a33.c > > index d73a93a132..355fe30aba 100644 > > --- a/arch/arm/mach-sunxi/dram_sun8i_a33.c > > +++ b/arch/arm/mach-sunxi/dram_sun8i_a33.c > > @@ -146,7 +146,7 @@ static void auto_set_timing_para(struct dram_para *para) > > writel(reg_val, &mctl_ctl->dramtmg5); > > /* Set two rank timing and exit self-refresh timing */ > > clrsetbits_le32(&mctl_ctl->dramtmg8, (0xff << 8) | (0xff << 0), > > - 0x33 << 8 | (0x8 << 0)); > > + 0x33 << 8 | (0x10 << 0)); > > How exactly does the change in constants match up with the commit message? > What is the field at “<< 0”? >
I just reduce the code change. Ok, forget to mention in the commit message that I don't have documentation of the cpu. So my fix is based on allwinner architecture comparison and the fact that it fix my issue. I was having a failure rate of 7% before. > Are you configuring the IOs to 1.5V with this write (as the commit message > would suggest)? No, the model of the memory is LPDDR3 but they can work as DDR3 compatible mode if they are powered at 1.5V. A33 has not support for LPDDR3 so make no sense to try to let them work as LPDDR3. I will update the commit message Michael > > > /* Set phy interface time */ > > reg_val = (0x2 << 24) | (t_rdata_en << 16) | (0x1 << 8) > > | (wr_latency << 0); > > -- > > 2.17.1 > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
