> -----Original Message----- > From: Fabio Estevam [mailto:[email protected]] > Sent: 2019年2月14日 21:36 > To: [email protected] > Cc: [email protected]; Peng Fan <[email protected]>; Fabio Estevam > <[email protected]> > Subject: [PATCH v2] mx6ul_14x14_evk: Simplify the PMIC register writes > > There is no need to store the values written to the PMIC inside the 'reg' > variable. Make it simpler by writing the values directly. > > Signed-off-by: Fabio Estevam <[email protected]> > --- > Changes since v1: > - Remove 1/2 notation, since this is a standalome patch > - Add Peng Fan on Cc > > board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c > b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c > index 595ad76bbe..636c008993 100644 > --- a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c > +++ b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c > @@ -86,16 +86,13 @@ int power_init_board(void) > pmic_reg_write(dev, PFUZE3000_LDOGCTL, reg); > > /* SW1B step ramp up time from 2us to 4us/25mV */ > - reg = 0x40; > - pmic_reg_write(dev, PFUZE3000_SW1BCONF, reg); > + pmic_reg_write(dev, PFUZE3000_SW1BCONF, 0x40); > > /* SW1B mode to APS/PFM */ > - reg = 0xc; > - pmic_reg_write(dev, PFUZE3000_SW1BMODE, reg); > + pmic_reg_write(dev, PFUZE3000_SW1BMODE, 0xc); > > /* SW1B standby voltage set to 0.975V */ > - reg = 0xb; > - pmic_reg_write(dev, PFUZE3000_SW1BSTBY, reg); > + pmic_reg_write(dev, PFUZE3000_SW1BSTBY, 0xb);
Reviewed-by: Peng Fan <[email protected]> > > return 0; > } > -- > 2.17.1 _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
