On 3/5/19 11:28 PM, Eugeniu Rosca wrote: > On Tue, Mar 05, 2019 at 07:56:39PM +0100, Marek Vasut wrote: >> On 3/5/19 7:42 PM, Eugeniu Rosca wrote: >>> Hello Marek, >> >> Hi, >> >>> May I ask for your opinion on Renesas commits [1-2] especially in >>> light of the `bootm_size` changes done in your patch? >>> The topics look orthogonal to me, but I kindly ask for your confirmation. >> >> What do you want to know ? With that commit, U-Boot is sitting in the >> middle of your RAM and you're likely to overwrite or corrupt it sooner >> or later, so that patch is not going upstream. > > That's already very helpful. Thanks. > >> >>> Also, purely related to the `bootm_size` patch, compiling v2019.04-rc3 >>> U-Boot for H3-Salvator-X with the diff [3] applied, I get: >>> >>> common/image.c: In function 'env_get_bootm_mapsize': >>> common/image.c:520:2: error: #error "Take bootm_size from CONFIG" >>> #error "Take bootm_size from CONFIG" >>> ^~~~~ >>> >>> Does this mean the "CONFIG_SYS_BOOTMAPSZ" definition has to be removed >>> from include/configs/rcar-gen3-common.h, to allow the patch to have >>> the desired effect? >> >> Possibly, if you could study it a bit and if that's the case, send a >> patch, that'd be nice. > > Submitted https://patchwork.ozlabs.org/patch/1052012/
Nice , thanks! -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
