Hi Lukasz, > -----Original Message----- > From: Lukasz Majewski [mailto:[email protected]] > Sent: Monday, April 01, 2019 1:03 PM > To: Siva Durga Prasad Paladugu <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Michal Simek > <[email protected]> > Subject: Re: [PATCH] usb: dwc3: Handle case where setup_phy is not > needed > > Hi Siva Durga Prasad Paladugu, > > > If CONFIG_PHY is not enabled then the dwc3_setup_phy() returns > > ENOTSUPP which can be still valid and intentional > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ - could you > elaborate on this a bit more? > > What is the use case when -ENOTSUPP is valid and intentional ?
In the cases where phy will be setup by First stage boot loader itself and don't want to do it again at u-boot. Thanks, Siva > > > so modify error check to handle this -ENOTSUPP. > > > > Signed-off-by: Siva Durga Prasad Paladugu > > <[email protected]> --- drivers/usb/dwc3/dwc3-generic.c > > | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/dwc3/dwc3-generic.c > > b/drivers/usb/dwc3/dwc3-generic.c index 3e6c494..a261d8d 100644 > > --- a/drivers/usb/dwc3/dwc3-generic.c > > +++ b/drivers/usb/dwc3/dwc3-generic.c > > @@ -47,7 +47,7 @@ static int dwc3_generic_peripheral_probe(struct > > udevice *dev) struct dwc3 *dwc3 = &priv->dwc3; > > > > rc = dwc3_setup_phy(dev, &priv->phys, &priv->num_phys); > > - if (rc) > > + if (rc && rc != -ENOTSUPP) > > return rc; > > > > dwc3->regs = map_physmem(priv->base, DWC3_OTG_REGS_END, > > MAP_NOCACHE); > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > [email protected] _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
