On Mon, Apr 01, 2019 at 03:46:20PM +0200, Stefano Babic wrote: > Hi Otavio, > > On 01/04/19 15:20, Otavio Salvador wrote: > > Hello everyone, > > > > On Wed, Feb 27, 2019 at 10:44 PM Fabio Estevam <feste...@gmail.com> wrote: > >> On Wed, Jan 2, 2019 at 4:59 AM Baruch Siach <bar...@tkos.co.il> wrote: > >>> Use a single '=' to test string equality for compatibility with non-bash > >>> shells. Otherwise, if /bin/sh is dash, build fails: > >>> > >>> ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator > >>> ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator > >>> ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator > >>> ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator > >>> WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is > >>> not-functional > >>> > >>> Signed-off-by: Baruch Siach <bar...@tkos.co.il> > >> > >> I don't see this patch applied yet. > >> > >> Do we have other solution? > > > > This is still broken and the proposed patch does fix it. We should get > > this merged for 2019.04 release. > > > > Please Stefano, consider this for release (be it through your branch > > for directly by Tom). > > > > The thing is in which conditions this is broken and why it should be > fixed here and in this way. Yes, I admit, I have not pondered this as a > big issue - it could be also fixed replacing dash with bash on > Debian-like distros, and I guess also on not-debian. And I am quite sure > we cannot ensure compatibility with all possible shell that a customer > will try , from csh to some exotic variant. Why is this so important to > be rapidely fixed here ?
The script says it uses /bin/sh and not /bin/bash, so you cannot do bashism in there. -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
