On 4/11/19 8:25 AM, Simon Goldschmidt wrote:
> On Wed, Apr 10, 2019 at 2:01 PM Marek Vasut <[email protected]> wrote:
>>
>> The generic timer count is an incrementing 64bit value and a timer driver
>> must return an incrementing 64bit value. The DW APB timer only provides a
>> 32bit timer counting down, thus the result must be inverted and converted
>> to a 64bit value. The current implementation is however missing the 64bit
>> up-conversion and this results in random timer roll-overs, which in turn
>> triggers random timeouts throughout the codebase.
>>
>> This patch adds the missing 64bit up-conversion to fix the issue.
>>
>> Signed-off-by: Marek Vasut <[email protected]>
>> Cc: Chin Liang See <[email protected]>
>> Cc: Dinh Nguyen <[email protected]>
>> Cc: Ley Foon Tan <[email protected]>
>> Cc: Simon Goldschmidt <[email protected]>
>> Cc: Tien Fong Chee <[email protected]>
> 
> Reviewed-by: Simon Goldschmidt <[email protected]>

Maybe it's time to convert Gen5 to this timer driver too :)

-- 
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Reply via email to