Hello Trent,
Am 16.04.2019 um 00:02 schrieb Trent Piepho:
It is not very clear how these work in relation to the exact I2C xfers
they produce. In paticular, the address length is somewhat overloaded
in the read method. Clearly document the existing behavior. Maybe this
will help the next person who needs to work on this driver and not break
non-DM boards.
Cc: Nandor Han <[email protected]>
Cc: Heiko Schocher <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Breno Matheus Lima <[email protected]>
Signed-off-by: Trent Piepho <[email protected]>
---
drivers/i2c/mxc_i2c.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
Thanks, but your patch has a lot of checkpatch errors:
total: 34 errors, 0 warnings, 0 checks, 52 lines checked
please fix this and send a v2.
Reviewed-by: Heiko Schocher <[email protected]>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot
