Simon, There were a couple of issues with your patches (two appear to be malformed - the README and the 'fifo_threshold' one, looked like a linewrap issue, and the defconfig changes just didn't match up exactly w/TOT tegra/master after rebasing against TomR's main master). I was able to fix them all, but you should pull down the latest u-boot-tegra/master and check that all of the nyan patches look correct. All Tegra builds are OK and is now in Stephen's Jenkins test framework. If it passes, and I get a thumbs-up from you, I'll send a PR to TomR.
Tom -----Original Message----- From: Tom Warren Sent: Wednesday, May 22, 2019 8:51 AM To: Simon Glass <[email protected]>; U-Boot Mailing List <[email protected]> Cc: Jonathan Hunter <[email protected]>; Stephen Warren <[email protected]>; Stephen Warren <[email protected]> Subject: RE: [PATCH v2 0/7] sound: Add sound support for Nyan Simon, -----Original Message----- From: Simon Glass <[email protected]> Sent: Wednesday, May 22, 2019 6:25 AM To: U-Boot Mailing List <[email protected]> Cc: Jonathan Hunter <[email protected]>; Stephen Warren <[email protected]>; Stephen Warren <[email protected]>; Tom Warren <[email protected]> Subject: Re: [PATCH v2 0/7] sound: Add sound support for Nyan Hi Tom, On Mon, 1 Apr 2019 at 14:38, Simon Glass <[email protected]> wrote: > > This series adds sound support for Nyan. It allows simple beeps to be > generated in U-Boot. This requires the addition of an I2S driver, an > audio hub driver and a sound driver to pull things together. An > existing audio codec (MAX98090) is used. > > Changes in v2: > - Fix 'I2C' typo > - Drop setting of slot_ctrl from i2s_tx_init() > > Simon Glass (7): > tegra: Correct tegra124 clock name > tegra: Add a delay in clock_start_periph_pll() > tegra: sound: Add an audio hub driver > tegra: sound: Add an I2S driver > sound: tegra: Add a sound driver > tegra: nyan-big: Enable sound > tegra: nyan: Add a README > > arch/arm/include/asm/arch-tegra/tegra_ahub.h | 475 > +++++++++++++++++++ arch/arm/include/asm/arch-tegra/tegra_i2s.h | > +++++++++++++++++++ 206 ++++++++ > arch/arm/mach-tegra/clock.c | 1 + > arch/arm/mach-tegra/tegra124/clock.c | 2 +- > board/nvidia/nyan-big/README | 18 + > board/nvidia/nyan-big/nyan-big.c | 2 +- > configs/nyan-big_defconfig | 7 + > drivers/sound/Kconfig | 9 + > drivers/sound/Makefile | 1 + > drivers/sound/tegra_ahub.c | 256 ++++++++++ > drivers/sound/tegra_i2s.c | 123 +++++ > drivers/sound/tegra_i2s_priv.h | 29 ++ > drivers/sound/tegra_sound.c | 100 ++++ > 13 files changed, 1227 insertions(+), 2 deletions(-) create mode > 100644 arch/arm/include/asm/arch-tegra/tegra_ahub.h > create mode 100644 arch/arm/include/asm/arch-tegra/tegra_i2s.h > create mode 100644 board/nvidia/nyan-big/README create mode 100644 > drivers/sound/tegra_ahub.c create mode 100644 > drivers/sound/tegra_i2s.c create mode 100644 > drivers/sound/tegra_i2s_priv.h create mode 100644 > drivers/sound/tegra_sound.c > This series still seems to be in limbo. How can this get applied? Yeah, sorry, I forgot about these. I'll try to get them applied this week. Tom Regards, Simon -- nvpublic _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
