Dear Scott Wood, In message <4bfed090.1040...@freescale.com> you wrote: > > If you set maxsize beyond what you expect to find, how are you going to > constrain it to operating on one bank?
Maybe it helps if you read section "System Initialization" in teh README; this explains the original design when I implemented this a decade ago. > > Such configurations are usually set up of from several differently > > sized banks of memory, and get_ram_size() is always run per bank. So > > as long as chip manufacturers continue to make RAM chips with > > power-of-two sizes only, everything should be fine. > > So it's not the board code at all that should be calling this, it's the > SDRAM code? Which is already in u-boot, and not in this patch (other > than some board-specific tweaks)? I don't know where you initialize the RAM. > Let's not. It can be crowded enough as is, we don't need more > restrictions coming from u-boot wanting to do questionable and > unnecessary things. Well, what seems unnecessary to you is actually pretty important to others. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I realize that command does have its fascination, even under circum- stances such as these, but I neither enjoy the idea of command nor am I frightened of it. It simply exists, and I will do whatever logi- cally needs to be done. -- Spock, "The Galileo Seven", stardate 2812.7 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot