On 6/10/19 4:24 PM, Stefano Babic wrote: > Hi Marek, > > On 12/05/19 22:43, Marek Vasut wrote: >> Drop the ad-hoc AHCI binding code, this is superseded by >> CONFIG_DWC_AHSATA_AHCI=y resp. drivers/ata/dwc_ahsata.c >> >> Signed-off-by: Marek Vasut <[email protected]> >> Cc: Christopher Spinrath <[email protected]> >> Cc: Fabio Estevam <[email protected]> >> Cc: Igor Grinberg <[email protected]> >> Cc: Nikita Kiryanov <[email protected]> >> Cc: Stefano Babic <[email protected]> >> --- >> board/compulab/cm_fx6/cm_fx6.c | 63 ---------------------------------- >> configs/cm_fx6_defconfig | 1 - >> 2 files changed, 64 deletions(-) >> >> diff --git a/board/compulab/cm_fx6/cm_fx6.c b/board/compulab/cm_fx6/cm_fx6.c >> index d42f57d4b7..b8f15cf3ab 100644 >> --- a/board/compulab/cm_fx6/cm_fx6.c >> +++ b/board/compulab/cm_fx6/cm_fx6.c >> @@ -724,66 +724,3 @@ U_BOOT_DEVICE(cm_fx6_serial) = { >> .name = "serial_mxc", >> .platdata = &cm_fx6_mxc_serial_plat, >> }; >> - >> -#if CONFIG_IS_ENABLED(AHCI) >> -static int sata_imx_probe(struct udevice *dev) >> -{ >> - int i, err; >> - >> - /* Make sure this gpio has logical 0 value */ >> - gpio_direction_output(CM_FX6_SATA_PWLOSS_INT, 0); >> - udelay(100); >> - cm_fx6_sata_power(1); > > cm_fx6_sata_power() is still defined and not used in the board, this > raises at least a warning (apart of Christopher's comments). >
AFAIR Christopher will be fixing this patch, so drop it. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
