On 6/19/19 6:56 AM, [email protected] wrote: > Hello Robert, > > I am not an expert on this, but I have been modifying a watchdog driver > lately. Please check my comments below, although they may need a review from > the corresponding maintainer: > >> -----Original Message----- >> From: U-Boot <[email protected]> On Behalf Of Robert Hancock >> Sent: Wednesday, June 19, 2019 12:53 AM >> To: [email protected] >> Subject: [U-Boot] [PATCH] driver: watchdog: Add new iMX/LSCH2 WDT driver >> >> This is a new watchdog timer driver for iMX and LSCH2 using the WDT >> framework and driver model. This allows ensuring that U-Boot uses the >> same watchdog timer instance and same settings (ex: internal or external >> reset) specified in the device tree. >> >> This driver can be used in preference to the old imx_watchdog driver for >> boards which have been converted to use the driver model. >> >> Signed-off-by: Robert Hancock <[email protected]> >> --- >> drivers/watchdog/Kconfig | 14 ++++-- >> drivers/watchdog/Makefile | 3 ++ >> drivers/watchdog/imx_wdt.c | 112 > > Why don't you overwrite drivers/watchdog/imx_watchdog.c? >
Because there are still non-DM systems using it. However, I posted patches to add DM and DT probing support for imx_watchdog, so use that. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
