Re: [U-Boot] [PATCH v7 9/9] net: macb: Fix check for little-endian system in gmac_configure_dma()

[Ramon Fried]

On 6/24/19 8:03 AM, Bin Meng wrote:
> On Mon, Jun 24, 2019 at 12:03 PM Anup Patel <anup.pa...@wdc.com> wrote:
>> We should depend on __LITTLE_ENDIAN pre-defined compiler macro for
>> little-endian system instead of U-Boot specific CONFIG_SYS_LITTLE_ENDIAN
>> macro.
>>
>> Signed-off-by: Anup Patel <anup.pa...@wdc.com>
>> ---
>>  drivers/net/macb.c | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
> Reviewed-by: Bin Meng <bmeng...@gmail.com>
Hi.
I don't like this approach, each platform should configure it's
endianess, this is stated in README in root folder.
relying on a specific GCC preprocessor extension is limiting us only to use GCC.
The RISCV issue with MACB can be easily resolved by defining the
CONFIG_SYS_LITTLE_ENDIAN config.
Thanks,
Ramon.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot