Hi Eugeniu,
On Wed, Jun 26, 2019 at 1:12 AM Eugeniu Rosca <roscaeuge...@gmail.com> wrote:
>
> Hi Sam,
>
> On Thu, Jun 20, 2019 at 05:00:01PM +0300, Sam Protsenko wrote:
> > As per [1], there is no such fastboot variable as "bootloader-version".
> > Only "version-bootloader" is supported. Let's reflect this and not
> > confuse users further.
> >
>
> FWIW, this could carry a Fixes line?
> Fixes: 3aab70afc531d1 ("usb/gadget: add the fastboot gadget")
>
> I strongly believe there are ongoing attempts/projects to build
> relationships/dependencies between commits, which would help in the
> context of bug prediction. Code Maat [2] comes to mind, but there could
> be better examples.
>
> > [1]
> > https://android.googlesource.com/platform/system/core/+/master/fastboot/README.md#client-variables
> [2] https://github.com/adamtornhill/code-maat
>
> In case AOSP gives it a second thought and drops or renames the
> "is-userspace" option or the Client Variables section (both unlikely,
> but possible), then the link will point to the wrong contents. This
> happened to me in the past, but I am lazy to look for some records.
>
> [..]
>
> > diff --git a/doc/README.android-fastboot b/doc/README.android-fastboot
> > index 431191c473..ce852a4fd1 100644
> > --- a/doc/README.android-fastboot
> > +++ b/doc/README.android-fastboot
> > @@ -169,8 +169,8 @@ On the client side you can fetch the bootloader version
> > for instance:
> >
> > ::
> >
> > - $ fastboot getvar bootloader-version
> > - bootloader-version: U-Boot 2014.04-00005-gd24cabc
> > + $ fastboot getvar version-bootloader
> > + version-bootloader: U-Boot 2014.04-00005-gd24cabc
>
> I am afraid this may introduce confusion, specifically that v2014.04+
> (more precisely v2014.04-207-g3aab70afc531) U-Boot responded properly
> to 'fastboot getvar version-bootloader'. Please, feel free to ignore.
>
> [..]
>
> > @@ -37,12 +37,9 @@ static const struct {
> > {
> > .variable = "version",
> > .dispatch = getvar_version
> > - }, {
> > - .variable = "bootloader-version",
> > - .dispatch = getvar_bootloader_version
> > }, {
>
> On one hand, I agree with Igor that certain users might be hurt by
> this change. On the other hand, it sounds good not to spend time and
> effort maintaining non-AOSP options, added to U-Boot by accident.
>
All comments are addressed in v2. Thanks!
> Reviewed-by: Eugeniu Rosca <ero...@de.adit-jv.com>
>
> Thanks!
>
> --
> Best Regards,
> Eugeniu.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
