On Fri, Jun 4, 2010 at 2:58 PM, John Rigby <[email protected]> wrote: > Aneesh: > > On Tue, May 25, 2010 at 12:39 AM, Aneesh V <[email protected]> wrote: >> Adding support for OMAP4430 SDP board based on the TI OMAP4430 SOC. > > --- > > arch/arm/cpu/armv7/omap4/reset.S: > Identical to omap3 version. I think they should be shared. Perhaps > have a arch/arm/cpu/armv7/omap directory for shared files.
How about we call it omap-common? Is there a good example of how to handle this shared code? The existing build system will only build the contents of the omap4 directory and not omap-common. Offhand I don't see any other architectures that do this, so I thought I would ask before making something up :-) Steve > arch/arm/cpu/armv7/omap4/timer.c: > Apart from the include of asm/arch/omap4.h this file is identical to > the omap3 version. See sharing comment above. > > arch/arm/include/asm/arch-omap4/cpu.h: > I think there is opportunity for sharing here as well. Not the whole file > so some refactoring needs to happen. > > Thanks, > John > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
