On 2019/7/16 上午2:20, Jagan Teki wrote:
Add proper return type handling of pctl_cfg with
meaningful print statement.

Signed-off-by: Jagan Teki <[email protected]>

Reviewed-by: Kever Yang <[email protected]>

Thanks,
 - Kever
---
  drivers/ram/rockchip/sdram_rk3399.c | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/ram/rockchip/sdram_rk3399.c 
b/drivers/ram/rockchip/sdram_rk3399.c
index c918c2e588..de5d8c1b5f 100644
--- a/drivers/ram/rockchip/sdram_rk3399.c
+++ b/drivers/ram/rockchip/sdram_rk3399.c
@@ -1063,6 +1063,7 @@ static int sdram_init(struct dram_info *dram,
        unsigned char dramtype = params->base.dramtype;
        unsigned int ddr_freq = params->base.ddr_freq;
        int channel;
+       int ret;
debug("Starting SDRAM initialization...\n"); @@ -1082,9 +1083,10 @@ static int sdram_init(struct dram_info *dram,
                if (channel >= params->base.num_channels)
                        continue;
- if (pctl_cfg(chan, channel, params) != 0) {
-                       printf("pctl_cfg fail, reset\n");
-                       return -EIO;
+               ret = pctl_cfg(chan, channel, params);
+               if (ret < 0) {
+                       printf("%s: pctl config failed\n", __func__);
+                       return ret;
                }
/* LPDDR2/LPDDR3 need to wait DAI complete, max 10us */


_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Reply via email to