Hi, Lukasz
> > On Thu, 18 Jul 2019 07:38:10 +0000 > Peng Fan <peng....@nxp.com> wrote: > > > Hi Lukasz, > > > > > Subject: Re: [PATCH 1/4] imx: spl: Change USB boot device type > > > > > > Hi Sherry, > > > > > > > From: Sherry Sun <sherry....@nxp.com> > > > > > > > > The SPL SDP is configured as BOOT_DEVICE_BOARD, so when booting > > > > from USB, change its type to BOOT_DEVICE_BOARD, so we can use SDP. > > > > > > > > Signed-off-by: Sherry Sun <sherry....@nxp.com> > > > > Signed-off-by: Ye Li <ye...@nxp.com> > > > > --- > > > > arch/arm/mach-imx/spl.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c > > > > index 9f1e0f6a72..2355019243 100644 > > > > --- a/arch/arm/mach-imx/spl.c > > > > +++ b/arch/arm/mach-imx/spl.c > > > > @@ -156,7 +156,7 @@ u32 spl_boot_device(void) > > > > case SPI_NOR_BOOT: > > > > return BOOT_DEVICE_SPI; > > > > case USB_BOOT: > > > > - return BOOT_DEVICE_USB; > > > > + return BOOT_DEVICE_BOARD; > > > > > > Why this change is required? What is the problem you are trying to > > > solve here? (And it is always welcome if one write the detailed > > > description of the problem in the commit message). > > > > It is spl sdp need it. > > SPL_LOAD_IMAGE_METHOD("USB SDP", 0, BOOT_DEVICE_BOARD, > > spl_sdp_load_image); > > My point is why this error was not apparent earlier (or when I was using the > uuu with newest u-boot)? > > I'm just curious why let's say "average" uuu/SDP user did not encountered this > problem (as I had also to recover SPL on my i.MX6 board). This change is only available on imx8 and imx8m platform. For imx7, BOOT_DEVICE_BOARD has already been set at the beginning of u32 spl_boot_device(void). For imx6, BOOT_DEVICE_BOARD also has been set as below. 21#if defined(CONFIG_MX6) 22 /* determine boot device from SRC_SBMR1 (BOOT_CFG[4:1]) or SRC_GPR9 register */ 23 u32 spl_boot_device(void) 24 { 25 unsigned int bmode = readl(&src_base->sbmr2); 26 u32 reg = imx6_src_get_boot_mode(); 27 28 /* 29 * Check for BMODE if serial downloader is enabled 30 * BOOT_MODE - see IMX6DQRM Table 8-1 31 */ 32 if (((bmode >> 24) & 0x03) == 0x01) /* Serial Downloader */ 33 return BOOT_DEVICE_BOARD; > > > > > Regards, > > Peng. > > > > > > > > I've been using recently SDP (with uuu on imx6q) and I did not > > > experience any issues. > > > > > > > default: > > > > return BOOT_DEVICE_NONE; > > > > } > > > > > > > > > > > > > > > Best regards, > > > > > > Lukasz Majewski > > > > > > -- > > > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang > > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, > > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > > > lu...@denx.de > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > lu...@denx.de Best regards Sherry sun _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot