On Mon, Jul 22, 2019 at 11:41 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Wed, Jul 17, 2019 at 7:41 AM Park, Aiden <[email protected]> wrote:
> >
> > Slim Bootloader provides TSC clock information in its performance
> > info hob. For now, TSC clock information is only used for timer driver
> > from the performance info hob.
> > - Get TSC frequency from performance info hob
> > - Set tsc_base and clock_rate for timer driver
>
> So why do we need this at all? We have a common TSC driver that works
> for all x86.
>
Ah, yes! Thanks for the review. The U-Boot native TSC driver should
support this out of the box.
Aiden, could you please add a TSC DT node in the slimbootloader.dts
file, and have a try?
If the native U-Boot TSC driver does not work on your platform, I
think you need send a patch to update the TSC driver directly.
> > +#define LOADER_PERFORMANCE_INFO_GUID \
> > + { \
> > + 0x868204be, 0x23d0, 0x4ff9, \
> > + { 0xac, 0x34, 0xb9, 0x95, 0xac, 0x04, 0xb1, 0xb9 } \
> > + }
>
> Use EFI_GUID(), please.
>
> > +struct performance_info {
>
> Same, you better to make less generic names for data structs.
>
> > +} __packed;
>
Regards,
Bin
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot
