On Tue, Jul 23, 2019 at 9:15 AM Bin Meng <[email protected]> wrote:
> On Mon, Jul 22, 2019 at 11:49 PM Andy Shevchenko
> <[email protected]> wrote:
> > On Wed, Jul 17, 2019 at 7:42 AM Park, Aiden <[email protected]> wrote:
> > > board/intel/slimbootloader/README | 133 ++++++++++++++++++++
> >
> > Shouldn't become reST one?
>
> I think this will need be converted to reST after my doc series are applied.
I had an impression that reST conversion is targeting 2019.10. It
means in your branch you will have it applied earlier.
> > > +int board_early_init_r(void)
> > > +{
> > > + /*
> > > + * Make sure PCI bus is enumerated so that peripherals on the PCI
> > > bus
> > > + * can be discovered by their drivers
> > > + */
> > > + pci_init();
> >
> > I'm not sure this is how U-Boot is designed with DM.
> > At least my expectations that bus gets initialized followed by the
> > certain driver in a lazy way.
> > Isn't it the case? Bin?
>
> For most x86 board, yes, PCI gets enumerated automatically if some PCI
> APIs are called in the early initialization codes: eg: pci_{read,
> write}_config().
>
> But for boards like coreboot/slimbootloader, if there is no touch to
> any PCI config register on that board in the early phase, PCI bus
> remains not probed.
Thanks for explanation!
Perhaps this needs a comment in the code.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot