Hi Andy, > -----Original Message----- > From: Andy Shevchenko [mailto:[email protected]] > Sent: Friday, July 26, 2019 7:32 PM > To: Park, Aiden <[email protected]> > Cc: Bin Meng <[email protected]>; U-Boot Mailing List <u- > [email protected]>; Simon Glass <[email protected]> > Subject: Re: [PATCH v6 2/8] x86: Add a common HOB library > > On Fri, Jul 26, 2019 at 10:00 AM Park, Aiden <[email protected]> wrote: > > > > FSP(CONFIG_HAVE_FSP) and Slim Bootloader(CONFIG_SYS_SLIMBOOTLOADER) > > consume HOB(CONFIG_USE_HOB) data from the each HOB list pointer. > > Add a common HOB library in lib/hob.c and include/asm/hob.h. > > > #define FSP_HEADER_GUID \ > > - { \ > > - FSP_GUID_DATA1, FSP_GUID_DATA2, FSP_GUID_DATA3, \ > > - { FSP_GUID_DATA4_0, FSP_GUID_DATA4_1, FSP_GUID_DATA4_2, \ > > - FSP_GUID_DATA4_3, FSP_GUID_DATA4_4, FSP_GUID_DATA4_5, \ > > - FSP_GUID_DATA4_6, FSP_GUID_DATA4_7 } \ > > - } > > + EFI_GUID(FSP_GUID_DATA1, FSP_GUID_DATA2, FSP_GUID_DATA3, \ > > + FSP_GUID_DATA4_0, FSP_GUID_DATA4_1, FSP_GUID_DATA4_2, \ > > + FSP_GUID_DATA4_3, FSP_GUID_DATA4_4, FSP_GUID_DATA4_5, \ > > + FSP_GUID_DATA4_6, FSP_GUID_DATA4_7) > > This kind of change better to do in the separate patch (as a preparatory > action). > Let me split this patch into 2 separate patches. - One for making the existing FSP HOB library use EFI_GUID and efi_guid_t - Other for making a common library.
> -- > With Best Regards, > Andy Shevchenko Best Regards, Aiden _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
