On Sun, Jul 14, 2019 at 11:31:50PM +0200, Heinrich Schuchardt wrote:

> Packed structures like struct uuid are not aligned. GCC 9.1 therefore
> throws an error when trying to compile gen_rand_uuid().
> 
> lib/uuid.c: In function ‘gen_rand_uuid’:
> lib/uuid.c:244:2: error: converting a packed ‘struct uuid’ pointer
> (alignment 1) to a ‘unsigned int’ pointer (alignment 4) may result in
> an unaligned pointer value [-Werror=address-of-packed-member]
>   244 |  unsigned int *ptr = (unsigned int *)&uuid;
>       |  ^~~~~~~~
> 
> Generate the uuid in a properly aligned buffer.
> 
> The byte order of a random number should not matter. Do not call
> cpu_to_be32() to change the byte order.
> 
> Reported-by: Ramon Fried <[email protected]>
> Signed-off-by: Heinrich Schuchardt <[email protected]>

Applied to u-boot/master, thanks!

-- 
Tom

Attachment: signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Reply via email to