On 24/07/2019 14:22, Kever Yang wrote: > > On 2019/7/24 下午6:22, Simon Goldschmidt wrote: >> On Wed, Jul 24, 2019 at 12:01 PM Kever Yang <kever.y...@rock-chips.com> >> wrote: >>> The board_early_init_r() suppose to be called before board_init(), >>> then the board callback functions in board_r will be: >>> - board_early_init_r() >>> - board_init() >>> - board_late_init() >> Searching through the code, elixir.bootlin.com gives me 52 definitions >> of board_early_init_r(). Does this patch break any of those boards >> when it changes the order of those calls? > > I do have check some of the implement and most of them should be OK, but to be > honest, > > I'm don't have any of those boards, and not sure if this break any of them, > and > I'm not sure > > if people using this interface have notice it's after the board_init(). > > When I try to use this board_early_init_r(), I thought this is before > board_init(), but it actually > > after the board_init(), that make people confusing. > > I think the _early_ one should be at the first, isn't it?
I agree. Maybe we should rename it to board_post_init? Regards, Matthias _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot