On Wed, Aug 14, 2019 at 12:09 PM Nevo Hed <nhed+ub...@starry.com> wrote: > > On Wed, Aug 14, 2019 at 11:39 AM Joe Hershberger > <joe.hershber...@gmail.com> wrote: > > > > On Fri, Aug 2, 2019 at 12:54 PM <nhed+ub...@starry.com> wrote: > > > > > > From: Ken Ma <m...@marvell.com> > > > > > > > - > > > -static int mvpp2_recv(struct udevice *dev, int flags, uchar **packetp) > > > +int mvpp2_recv(struct udevice *dev, int flags, uchar **packetp) > > > > Why does this need to be visible outside of this translation unit? > > Hi Joe > > Yes you are right, it should remain static. This was in the > downstream commit from Ken I pulled in - I reversed that and made it > static again in my later commit in same patchset > > https://patchwork.ozlabs.org/patch/1142905/ > > let me know if it is preferred to rewrite this commit (I just don't > know what the right way when submitting changes by others where the > others' org instructed them to abandoned them)
When it is something minor like this, it's reasonable to simply make the small adjustment and a brief comment in the commit log and leave the author attribution. Cheers, -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
