++ Xiaowei Bao (he is taking over from Chuanhua) > -----Original Message----- > From: Wolfgang Denk <[email protected]> > Sent: Friday, August 23, 2019 2:53 PM > To: Chuanhua Han <[email protected]> > Cc: [email protected]; Prabhakar Kushwaha > <[email protected]>; Priyanka Jain <[email protected]>; > Rajesh Bhagat <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: Re: [PATCH v4 1/4] rtc: ds3232/ds3231: Add support to generate 32KHz > output for driver module > > Dear Chuanhua Han, > > In message <[email protected]> you wrote: > > This patch add an implementation of the rtc_enable_32khz_output() that > > uses the driver model i2c APIs. > ... > > + ret = i2c_get_chip_for_busnum(busnum, chip_addr, 1, &dev); > > + if (!ret) > > + ret = dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR, > > + RTC_STAT_BIT_BB32KHZ | > > + RTC_STAT_BIT_EN32KHZ); > > Strictly speaking, this is a multi-line statement following the "if" > so braces are required according to the coding style: > > if (!ret) { > ret = dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR, > RTC_STAT_BIT_BB32KHZ |) > RTC_STAT_BIT_EN32KHZ); > } >
Dear Wolfgang, Unfortunately this patch has been merged in main-line. But I will ask (Xiaowei Bao) to send patch to fix it. I will make sure to get fix in RC3 or RC4. --pk _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
