Hi, On Thu, Sep 26, 2019 at 6:50 PM Simon Glass <s...@chromium.org> wrote: > > Hi Doug, > > On Tue, 3 Sep 2019 at 13:15, Douglas Anderson <diand...@chromium.org> wrote: > > > > As per the centithread on ksummit-discuss [1], there are folks who > > feel that if a Change-Id is present in a developer's local commit that > > said Change-Id could be interesting to include in upstream posts. > > Specifically if two commits are posted with the same Change-Id there's > > a reasonable chance that they are either the same commit or a newer > > version of the same commit. Specifically this is because that's how > > gerrit has trained people to work. > > > > There is much angst about Change-Id in upstream Linux, but one thing > > that seems safe and non-controversial is to include the Change-Id as > > part of the string of crud that makes up a Message-Id. > > > > Let's give that a try. > > > > In theory (if there is enough adoption) this could help a tool more > > reliably find various versions of a commit. This actually might work > > pretty well for U-Boot where (I believe) quite a number of developers > > use patman, so there could be critical mass (assuming that enough of > > these people also use a git hook that adds Change-Id to their > > commits). I was able to find this git hook by searching for "gerrit > > change id git hook" in my favorite search engine. > > > > In theory one could imagine something like this could be integrated > > into other tools, possibly even git-send-email. Getting it into > > patman seems like a sane first step, though. > > > > NOTE: this patch is being posted using a patman containing this patch, > > so you should be able to see the Message-Id of this patch and see that > > it contains my local Change-Id, which ends in 2b9 if you want to > > check. > > > > [1] > > https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2019-August/006739.html > > > > Signed-off-by: Douglas Anderson <diand...@chromium.org> > > --- > > > > Changes in v2: > > - Add a "v" before the version part of the Message-Id > > - Reorder the parts of the Message-Id as per Johannes. > > > > tools/patman/README | 8 +++++- > > tools/patman/commit.py | 3 ++ > > tools/patman/patchstream.py | 57 +++++++++++++++++++++++++++++++++++-- > > 3 files changed, 65 insertions(+), 3 deletions(-) > > Sadly this seems to cause a test failure (patman --test). Can you please > check?
It's been so long since I worked on patman that I totally forgot about patman --test. Doh! I've posted v3 and tests pass now. Hopefully it looks OK? -Doug _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot